Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nx-monorepo scripts and generator #371

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

JeremyJonas
Copy link
Contributor

  • Update docs to use @aws-prototyping-sdk/nx-monorepo directly to create new projects, which will solve bin linking issues
  • Fix yarn exec issue with arg propagation
  • Fix bin resolution issue for yarn

Fixes #365

The @ symbol in bin does not resolve for yarn, it works in npm and pnpm,
but yarn fails. So replacing with hyphen.
`yarn exec nx run-many ...` does not propagate args. This command
would need to be `yarn exec nx "run-many ..."` to work as expected.

By removing the exec and just letting yarn handle native exec
functionality, all the args are propagated as expected.
Update docs to directly call individual packages instance of bundled
aws-prototyping-sdk which is being deprecated soon.

Fixed aws#365
@nx-cloud
Copy link

nx-cloud bot commented Apr 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 16f7f4a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx run-many --target=build --output-style=stream --nx-bail
✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link
Contributor

@martenpayne martenpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from minor issue with README wording (and Jack's comment), the code changes look good

packages/aws-prototyping-sdk/README.md Show resolved Hide resolved
@JeremyJonas JeremyJonas merged commit cf57586 into aws:mainline Apr 27, 2023
3 checks passed
@JeremyJonas JeremyJonas deleted the fix/nx-bundled-script branch April 27, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Workspace linking for constructs is not working
3 participants