Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capabilities in samconfig.toml does not support list #2417

Closed
benkehoe opened this issue Nov 25, 2020 · 1 comment
Closed

capabilities in samconfig.toml does not support list #2417

benkehoe opened this issue Nov 25, 2020 · 1 comment
Labels
contributors/good-first-issue Good first issue for a contributor type/feature Feature request

Comments

@benkehoe
Copy link

In samconfig.toml, parameter_overrides is able to be a list of strings, which helps format the file better (though see #2253 for a request that this be improved).

I expected that I could do the same with capabilities when I have multiple capabilities. For example:

version = 0.1
[default]
[default.deploy]
[default.deploy.parameters]
capabilities = [
  "CAPABILITY_IAM",
  "CAPABILITY_NAMED_IAM"
]
parameter_overrides = [
  "Foo=Bar"
]

However, this gives me the error AttributeError: 'Array' object has no attribute 'split'.

It appears that this function should handle conversion to tuple for the type tomlkit.items.Array

def _space_separated_list_func_type(value):

@CoshUS CoshUS added type/feature Feature request contributors/good-first-issue Good first issue for a contributor labels Nov 27, 2020
@mgrandis mgrandis added the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Jan 13, 2021
@aahung
Copy link
Contributor

aahung commented Jan 30, 2021

v1.16.0 is released, please reopen if the issue still persists

@aahung aahung closed this as completed Jan 30, 2021
@aahung aahung removed the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributors/good-first-issue Good first issue for a contributor type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants