Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --parameter-values in 0.3.0 #456

Closed
metaskills opened this issue Jun 2, 2018 · 5 comments
Closed

Support for --parameter-values in 0.3.0 #456

metaskills opened this issue Jun 2, 2018 · 5 comments

Comments

@metaskills
Copy link
Contributor

I read issue #400 and it seems that SAM local no longer supports the --parameter-values CloudFormation parameter now. Just want to make sure this is intentional and that the use of --env-vars is the preferred replacement when running locally?

I have not tested if actions like deploy support --parameter-values still. Just wondering what the general direction is with regard to these configs. Thanks in advance!

@sanathkr
Copy link
Contributor

sanathkr commented Jun 4, 2018

yes, --env-vars is the recommended solution for sam local suite of commands. But for deploy, --parameter-values is still available and won't be deprecated.

Does this unblock you?

@metaskills
Copy link
Contributor Author

Does this unblock you?

Thank you it does. That distinct will help me upgrade to v0.3.0 once this #457 is resolved. Thanks again! Closing this issue now too.

@onelaview
Copy link

onelaview commented Oct 18, 2018

yes, --env-vars is the recommended solution for sam local suite of commands.

Sadly that Lambda in AWS China (cn-north-1, for example) still doesn't support environment variables yet so --env-vars is not an applicable solution here. Please re-consider adding support for --parameter-values or --parameter-overrides argument to be able to pass a parameter to CloudFormation file for sam local invoke command.

@jfuss
Copy link
Contributor

jfuss commented Oct 18, 2018

@onelaview Soon! We have support for --parameter-overrides merged into develop (#657). This adds support for SAM CLI to resolve Refs of Parameters and pick up default values of those Parameters. It will be available in the next release. We will be closing #572 once this is available. Stay tuned! :)

@onelaview
Copy link

@jfuss Wowww! my wishing comes just true in minutes! No more sad. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants