Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debug JVM Parameters From Latest Lambda Settings #524

Closed
jaimm opened this issue Jul 2, 2018 · 4 comments
Closed

Update Debug JVM Parameters From Latest Lambda Settings #524

jaimm opened this issue Jul 2, 2018 · 4 comments

Comments

@jaimm
Copy link

jaimm commented Jul 2, 2018

https://github.com/awslabs/aws-sam-cli/blob/9ae4b80313d094d3eded4c5ca61731481b36c950/samcli/local/docker/lambda_container.py#L180-L182
Please see the corresponding issue (and commit) with docker-lambda for the latest values:
lambci/docker-lambda#102
The JVM memory parameters are currently out of date with what Lambda uses in production. docker-lambda has updated their settings, but you override them when users pass the debugging flags.

@jfuss
Copy link
Contributor

jfuss commented Jul 3, 2018

@jaimm Thanks for the issue. Would you be up for send a PR with the updated values?

@jaimm
Copy link
Author

jaimm commented Jul 3, 2018

Sorry, I'm pretty busy right now, otherwise I would. I just wanted to give you guys a heads-up with this issue since I already convinced docker-lambda to make the change.

@jason-riddle
Copy link
Contributor

Looks like the values are set here:

https://github.com/lambci/docker-lambda/blob/8eb1919506c9a947bda11770fbbe764ea6f1d9ec/java8/run/Dockerfile#L20-L22

ENTRYPOINT ["/usr/bin/java", "-XX:MaxHeapSize=2834432k", "-XX:MaxMetaspaceSize=163840k", "-XX:ReservedCodeCacheSize=81920k", \
  "-XX:+UseSerialGC", "-Xshare:on", "-XX:-TieredCompilation", "-Djava.net.preferIPv4Stack=true", \
  "-jar", "/var/runtime/lib/LambdaJavaRTEntry-1.0.jar"]

I'll open a PR for this.

@jfuss jfuss added the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Aug 14, 2018
@jfuss
Copy link
Contributor

jfuss commented Aug 29, 2018

Closing this as it was released in 0.6.0

@jfuss jfuss closed this as completed Aug 29, 2018
@jfuss jfuss removed the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants