Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No sam init for .net core 2.1 #609

Closed
DamianBis opened this issue Aug 7, 2018 · 4 comments
Closed

No sam init for .net core 2.1 #609

DamianBis opened this issue Aug 7, 2018 · 4 comments
Labels
area/init sam init contributors/good-first-issue Good first issue for a contributor priority/2-important stage/waiting-for-release Fix has been merged to develop and is waiting for a release type/feature Feature request

Comments

@DamianBis
Copy link

DamianBis commented Aug 7, 2018 •
edited

Description:

There is no sam init for dotnetcore2.1

Steps to reproduce the issue:

  1. run sam init --help
  2. see acceptable --runtime options
    -r, --runtime [go1.x|nodejs|python|python2.7|python3.6|go|nodejs4.3|nodejs6.10|java8|dotnetcore1.0|java|dotnetcore2.0|dotnetcore|dotnet|nodejs8.10]

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)
Windows

Output of sam --version:

SAM CLI, version 0.5.0
@jfuss
Copy link
Contributor

jfuss commented Aug 17, 2018

@DamianBis Yes, currently we do not have a .NET Core 2.1 sample. Would you be willing to add this? I am unsure if the dontnetcore2.0 will work in dotnetcore2.1 but if it does this should be an easy update.

@jfuss jfuss added the area/init sam init label Aug 17, 2018
@sanathkr
Copy link
Contributor

sanathkr commented Sep 7, 2018

@heitorlessa thoughts?

@sanathkr sanathkr added type/feature Feature request priority/2-important contributors/good-first-issue Good first issue for a contributor labels Sep 7, 2018
@heitorlessa
Copy link
Contributor

Working on a PR today for that @DamianBis.

@heitorlessa heitorlessa mentioned this issue Sep 13, 2018
Merged
@jfuss jfuss added the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Sep 27, 2018
@jfuss
Copy link
Contributor

jfuss commented Oct 24, 2018

Closing. Was released with 0.6.1

@jfuss jfuss closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/init sam init contributors/good-first-issue Good first issue for a contributor priority/2-important stage/waiting-for-release Fix has been merged to develop and is waiting for a release type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DamianBis @heitorlessa @sanathkr @jfuss