Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in Parameter Default not made on re-deploy (with 0.6.2, regression of #450?) #772

Closed
jrgm opened this issue Nov 18, 2018 · 1 comment

Comments

@jrgm
Copy link

jrgm commented Nov 18, 2018

Description:

I believe this was reported as fixed in #450 (comment) for version 0.6.1.

However, with 0.6.2, I'm not seeing a change of the default value reflected in the Cloudformation Parameters in the console, or in the Lambda function.

Steps to reproduce the issue:

  1. with template similar to the one below
  2. package and deploy
  3. Change the Default from red to blue
  4. Check Parameters on the Cloudformation stack, and the Environment on the Lambda function.

Notes:

  1. I've tried this also with --force-upload, but don't see a change that way either.
  2. If I set --parameter-overrides Color=blue, the change is made.

Example template structure:

AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Parameters:
  Color:
    Type: String
    Default: 'red'
Resources:
  MyFunction:
    Type: AWS::Serverless::Function
    Properties:
      CodeUri: MyFunction/
      Handler: index.main
      Runtime: nodejs8.10
      Environment:
        Variables:
          COLOR: !Ref Color
      Events:
        Get:
          Type: Api
          Properties:
            Path: /call
            Method: get

Output of sam --version:

$ sam --version
SAM CLI, version 0.6.2

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

Mac OSX

@jfuss
Copy link
Contributor

jfuss commented Dec 3, 2018

@jrgm The comment you linked is w.r.t sam local commands [invoke|start-api|start-lambda]. The options on package and deploy have not changed and rely on cloudformation's behavior for resolving parameters during stack update/creation.

Closing as there is no regression

@jfuss jfuss closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants