Cognito STS refused to be given to host application because bad compilation of cJSON

[Zykino]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• I've gone though Developer Guide and API reference
• I've searched for previous similar issues and didn't find any solution

Describe the bug
Full description can be fond on my StackOverflow question.

The TL;DR is that on a Qt app, with an Ubuntu configured with other locales than English, parsing the cognito credentials returns a bad value for the expiration which in turn return empty credentials to the application. This field look like this "Expiration":1.600435982E9 and cJSON is using strtod which is using the locale for decimal point (French decimal point is the comma ',' and not a dot '.').
By default cJSON is compiled with the use of local enabled but not in this SDK.

SDK version number
1.8.42

Platform/OS/Hardware/Device
Ubuntu 18.04, installed in English, set keyboard/date/numbers to French ones.

To Reproduce (observed behavior)
Please see the linked above stack overflow.

Expected behavior
Getting the STS token every-time. Whatever the environment is (Locales, Debugger, Qt, Android ?, ...)

Logs/output
Please see the linked above stack overflow.

Additional context
The cJSON version used in the SDK is quite old and should be updated/patched, for security reason if someone suddenly start to use cJSON_Minify at least.

[KaibaLopez]

ohh, that's kind of interesting.
Yea, thanks for pointing this out we'll take a look at it.

[jmklix]

We have changed how this sdk builds and made some updates to cJSON. Can you confirm if this is still happening for you?

[Zykino]

I don’t work there anymore. I think in the end we compiled the SDK with ENABLE_LOCALES so cJSON got it and compiled correctly.
I have no setup to check it now.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.