Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: Protocol tests for endpoint prefix are skipped #1631

Closed
3 tasks done
jasdel opened this issue Mar 17, 2022 · 1 comment · Fixed by #2243
Closed
3 tasks done

codegen: Protocol tests for endpoint prefix are skipped #1631

jasdel opened this issue Mar 17, 2022 · 1 comment · Fixed by #2243
Assignees
Labels
automation-exempt bug This issue is a bug. l Effort estimation: large p2 This is a standard priority issue

Comments

@jasdel
Copy link
Contributor

jasdel commented Mar 17, 2022

Documentation

Describe the bug

The SDK's protocol test code generation skips protocol tests that exercise endpoint prefix and host label traits. The SDK fully supports these features, but the protocol test runner expects the HTTP request to be made to a local test server. This is not valid for these tests since the endpoint prefix and host label modifies the endpoint, since endpoints are IP addresses, (e.g. http://foo.127.0.0.1:59850/).

Expected behavior

The tests cases should not be skipped, and test runner should exercise them correctly.

Current behavior

endpoint prefix and host label tests are skipped

Steps to Reproduce

make unit-modules-internal_protocoltest

Possible Solution

Update the generated test runner not to use test HTTP server. Instead process the HTTP request directly.

AWS Go SDK version used

release-2022-03-16

Compiler and Version used

go1.18

Operating System and version

macOS 12.2.1

@jasdel jasdel added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. automation-exempt and removed needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2022
@RanVaknin RanVaknin added p2 This is a standard priority issue l Effort estimation: large labels Nov 10, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation-exempt bug This issue is a bug. l Effort estimation: large p2 This is a standard priority issue
Projects
None yet
3 participants