Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset/zero-value region should explicitly fail endpoint resolution #2502

Closed
lucix-aws opened this issue Feb 17, 2024 · 1 comment · Fixed by #2503
Closed

Unset/zero-value region should explicitly fail endpoint resolution #2502

lucix-aws opened this issue Feb 17, 2024 · 1 comment · Fixed by #2503
Assignees
Labels
bug This issue is a bug. p1 This is a high priority issue

Comments

@lucix-aws
Copy link
Contributor

lucix-aws commented Feb 17, 2024

There was a subtle change with either the introduction of EndpointResolverV2 or AuthSchemeResolver (I haven't deep-dived yet) - an empty region string on client config now incorrectly gets passed to endpoint resolution, which tends to result in nonsense hostnames like ram..amazonaws.com.

This should instead result in the "region" endpoint parameter being effectively unset/nil which will cause endpoint resolution to fail with an error that's actually useful.

There has been a ton of very warranted customer confusion around this recently, see the following:

@lucix-aws lucix-aws added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1 This is a high priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Feb 17, 2024
@lucix-aws lucix-aws self-assigned this Feb 19, 2024
@lucix-aws lucix-aws removed the queued This issues is on the AWS team's backlog label Feb 19, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 This is a high priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant