Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DescribeAvailablePatches SSM api - incorrect type for the field epoch #2655

Closed
3 tasks done
svagner opened this issue Aug 3, 2021 · 8 comments
Closed
3 tasks done
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@svagner
Copy link

svagner commented Aug 3, 2021

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug

error while getting available patches","error":"SerializationError: failed decoding JSON RPC response\n\tstatus code: 200, request id: 5ff26977-ddee-4ddf-82cf-c88291a6cac0\ncaused by: unsupported value: <nil> (*int64)

Version of AWS SDK for Go?

v1.36.15

Version of Go (go version)?

go version go1.16.4 linux/amd64

To Reproduce (observed behavior)

	if err := DescribeAvailablePatchesPagesWithContext(ctx, &DescribeAvailablePatchesInput{
		Filters: []*PatchOrchestratorFilter{
			{
				Key: aws.String("PRODUCT"),
				Values: []*string{
					aws.String("AmazonLinux2.0"),
				},
			},
		},
		MaxResults: aws.Int64(50),
	}, func(result *DescribeAvailablePatchesOutput, lastPage bool) bool {
		res = append(res, result.Patches...)
		return !lastPage
	}); err != nil {
		return nil, err
	}

Expected behavior

The method should be finished without error

@svagner svagner added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 3, 2021
@KaibaLopez
Copy link
Contributor

Hi @svagner ,
Yea I am able ot reproduce this, thanks for bringing it up to us we'll review the PR.

@KaibaLopez KaibaLopez removed the needs-triage This issue or PR still needs to be triaged. label Aug 5, 2021
@jasdel
Copy link
Contributor

jasdel commented Feb 16, 2022

I updated, and had to close the PR because the SDK cannot take this change directly since these model files are copied into the SDK automatically. The copy would overwrite this change. In addition, this change breaks the SDK's public released type. Changing it from a int to string.

We'll need to forward this issue to the API team, to correct their API's behavior. This most likely is an issue with the service sending the wrong type in this specific case.

@jasdel jasdel added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Feb 16, 2022
@vudh1 vudh1 transferred this issue from aws/aws-sdk-go May 23, 2022
@vudh1
Copy link
Contributor

vudh1 commented Aug 26, 2022

V694669741

@vudh1 vudh1 assigned RanVaknin and unassigned vudh1 Sep 9, 2022
@RanVaknin
Copy link
Contributor

Unassigning.

Service team has auto closed this. This needs a re-triage. For whoever picks this up, if this cannot be reproduced with your SDK language, re-assign it to the Go SDK queue for follow up.

Thanks.

@ashishdhingra
Copy link

ashishdhingra commented Mar 27, 2024

Cannot be reproduced with AWS SDK for .NET using the code below:

using Amazon.SimpleSystemsManagement;
using Amazon.SimpleSystemsManagement.Model;

var response = await (new AmazonSimpleSystemsManagementClient()).DescribeAvailablePatchesAsync(newDescribeAvailablePatchesRequest()
{
     Filters = new List<PatchOrchestratorFilter>() {
        new PatchOrchestratorFilter() { Key="PRODUCT", Values = new List<string>(){ "AmazonLinux2.0" } }
     }
});

Console.WriteLine(response);

Transferring to AWS SDK for Go repo.

@ashishdhingra ashishdhingra transferred this issue from aws/aws-sdk Mar 27, 2024
@ashishdhingra ashishdhingra added needs-triage This issue or PR still needs to be triaged. and removed service-api This issue is due to a problem in a service API, not the SDK implementation. labels Mar 27, 2024
@ashishdhingra ashishdhingra removed their assignment Mar 27, 2024
@RanVaknin RanVaknin self-assigned this Apr 8, 2024
@RanVaknin RanVaknin transferred this issue from aws/aws-sdk-go May 23, 2024
@RanVaknin
Copy link
Contributor

Hi there,

I'm Not sure why @ashishdhingra is able to reproduce this with .NET. I tested this with the Go SDK and can see that the response field Epoch is set to return a value a string instead of a number as described in the API model.

I have created an internal ticket with the SSM service team ( P137583768) and will update you when we hear back from them. Sorry for the delay.

Ran~

@RanVaknin RanVaknin added service-api This issue is due to a problem in a service API, not the SDK implementation. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jun 26, 2024
@RanVaknin
Copy link
Contributor

Hi,

The service had acknowledged this needs to get fixed. Since it is not actionable by the Go SDK team, Im going to go ahead and close this.
Thanks,
Ran~

@RanVaknin RanVaknin closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

7 participants