Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/iot: Add support for MQTT Auth with PKI #706

Closed
ci-iotsyst opened this issue Jun 3, 2016 · 8 comments
Closed

service/iot: Add support for MQTT Auth with PKI #706

ci-iotsyst opened this issue Jun 3, 2016 · 8 comments
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@ci-iotsyst
Copy link

I got the AWS IoT samples to events to MQTT service, but only using AWS creds. I couldn't find anything in API to specify Thing key or cert or use root CA.

If this feature is missing, I would appreciate guidance on building a PR. My first step was to look at how js or C drivers do this and port that to go. The credentials.Credentials struct seems to be specific to AccessKey and SecretAccessKey so I'm not sure if this is the right place to refactor.

@xibz
Copy link
Contributor

xibz commented Jun 3, 2016

Hello @ci-iotsyst, thank you for reaching out to us. The JS library you are referring to is something IOT maintains. If you wanted to do something similar, you'd have to look at their code itself and mimic the logic. If you do make the library, it may be better to submit it as a new standalone project. In addition, it may be a good idea to browse the IOT forums for feedback. If you have any other questions, please let us know! I will reach out to IOT letting them know that there is interest in a library for Go. Going to go ahead and close this.

@xibz xibz added the guidance Question that needs advice or information. label Jun 3, 2016
@xibz xibz closed this as completed Jun 3, 2016
@ci-iotsyst
Copy link
Author

This is 100% supposed to be a part of the AWS IoT SDK. You create keys as part of the tutorial with the intent you use these to communicate. I'm ok with the fact this has not been coded yet, but this really shouldn't be closed. The AWS SDK has some IoT capability but it's missing this part which is rather critical for AWS IoT development.

@xibz
Copy link
Contributor

xibz commented Jun 3, 2016

@ci-iotsyst, that makes sense. We code-generate a lot of the code for services based off of the models. IOT has not added anything as of yet to allow the SDKs to do this. However, this would be a pretty big refactor in terms of how we deal with credentials. I will reopen this and mark it as a feature request and see why we had not done that with IOT from the start.

@xibz xibz reopened this Jun 3, 2016
@xibz xibz self-assigned this Jun 3, 2016
@xibz xibz added feature-request A feature should be added or improved. and removed guidance Question that needs advice or information. labels Jun 3, 2016
@xibz
Copy link
Contributor

xibz commented Jun 3, 2016

@ci-iotsyst - So, it seems that there is very little reason to use the SDK on embedded object, as the binaries can be quite large and there will be very little to no use of the SDK, but only IOT's SDK. This SDK is the SDK that IOT maintains So, with that said, does the alternative of submitting a project to IOT seem reasonable?

@ci-iotsyst
Copy link
Author

re: Go for IoT
https://gobot.io/

If you submit a feature request to remove all IoT stuff from SDK, then closing this issue would make sense otherwise I think you'd agree it's misleading of have IoT support that you aren't supposed to use
http://stackoverflow.com/questions/34409792/http-post-to-aws-iot-using-golang-and-aws-sdk-iotdataplane.

If code is generated from models, maybe just provide a hook in the generated code for people to implement their own auth. Go's PKI infrastructure is complete so I'm sure it's not a lot of work once we have a place to put it. I can take a crack at it and we can work backwards at how to work that into the SDK.

@ci-iotsyst
Copy link
Author

BTW: You've mentioned IOT as if it's a group or project. Is that a group internal to Amazon?

@xibz
Copy link
Contributor

xibz commented Jun 4, 2016

Yes, IOT is one of AWS' services. In addition, I have expressed your concerns in a message for IOT to get feedback. For now, I am leaving this as a feature request. I definitely understand why you would want to be able to have IOTs custom credential interface. So, if you have any additional feedback or questions, please let us know

@jasdel jasdel changed the title IoT API doesn't appear to support Auth using PKI service/iot: Add support for MQTT Auth with PKI Apr 12, 2017
@github-actions
Copy link

We have noticed this issue has not recieved attention in 3 years. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants