-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/iot: Add support for MQTT Auth with PKI #706
Comments
Hello @ci-iotsyst, thank you for reaching out to us. The JS library you are referring to is something |
This is 100% supposed to be a part of the AWS IoT SDK. You create keys as part of the tutorial with the intent you use these to communicate. I'm ok with the fact this has not been coded yet, but this really shouldn't be closed. The AWS SDK has some IoT capability but it's missing this part which is rather critical for AWS IoT development. |
@ci-iotsyst, that makes sense. We code-generate a lot of the code for services based off of the models. |
@ci-iotsyst - So, it seems that there is very little reason to use the SDK on embedded object, as the binaries can be quite large and there will be very little to no use of the SDK, but only |
re: Go for IoT If you submit a feature request to remove all IoT stuff from SDK, then closing this issue would make sense otherwise I think you'd agree it's misleading of have IoT support that you aren't supposed to use If code is generated from models, maybe just provide a hook in the generated code for people to implement their own auth. Go's PKI infrastructure is complete so I'm sure it's not a lot of work once we have a place to put it. I can take a crack at it and we can work backwards at how to work that into the SDK. |
BTW: You've mentioned IOT as if it's a group or project. Is that a group internal to Amazon? |
Yes, IOT is one of AWS' services. In addition, I have expressed your concerns in a message for IOT to get feedback. For now, I am leaving this as a feature request. I definitely understand why you would want to be able to have IOTs custom credential interface. So, if you have any additional feedback or questions, please let us know |
We have noticed this issue has not recieved attention in 3 years. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue. |
I got the AWS IoT samples to events to MQTT service, but only using AWS creds. I couldn't find anything in API to specify Thing key or cert or use root CA.
If this feature is missing, I would appreciate guidance on building a PR. My first step was to look at how js or C drivers do this and port that to go. The credentials.Credentials struct seems to be specific to AccessKey and SecretAccessKey so I'm not sure if this is the right place to refactor.
The text was updated successfully, but these errors were encountered: