aws/signer/v4: Remove logic determining if request needs to be resigned #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the relyability of the request signature by resigning the request each retry. In addition logic was added to the Send request handler chain to ensure the delay between Sign and Send will not prevent expired signature. This also brings the SDK in line with the other AWS SDKs in their behavior of resigning the request each retry. Related to aws#822
jasdel
added a commit
that referenced
this pull request
Oct 6, 2016
Service Model Updates --- `service/cognitoidentityprovider`: Update Amazon Cognito Identity Provider service model `service/devicefarm`: Update AWS Device Farm documentation `service/opsworks`: Update AWS OpsWorks service model `service/s3`: Update Amazon Simple Storage Service model `service/waf`: Update AWS WAF service model SDK Bug Fixes --- `aws/request`: Fix HTTP Request Body race condition #874 SDK Feature Updates --- `aws/ec2metadata`: Add support for EC2 User Data #872 `aws/signer/v4`: Remove logic determining if request needs to be resigned #876
Merged
jasdel
added a commit
that referenced
this pull request
Oct 6, 2016
Service Model Updates --- `service/cognitoidentityprovider`: Update Amazon Cognito Identity Provider service model `service/devicefarm`: Update AWS Device Farm documentation `service/opsworks`: Update AWS OpsWorks service model `service/s3`: Update Amazon Simple Storage Service model `service/waf`: Update AWS WAF service model SDK Bug Fixes --- `aws/request`: Fix HTTP Request Body race condition #874 SDK Feature Updates --- `aws/ec2metadata`: Add support for EC2 User Data #872 `aws/signer/v4`: Remove logic determining if request needs to be resigned #876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the reliability of the request signature by resigning the
request each retry. In addition logic was added to the Send request
handler chain to ensure the delay between Sign and Send will not prevent
expired signature. This also brings the SDK in line with the other AWS
SDKs in their behavior of resigning the request each retry.
Related to #822