Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS server-side encryption support #185

Closed
bonebox opened this issue May 1, 2015 · 6 comments
Closed

KMS server-side encryption support #185

bonebox opened this issue May 1, 2015 · 6 comments
Labels
feature-request Request a new feature

Comments

@bonebox
Copy link

bonebox commented May 1, 2015

The AWSS3PutObjectRequest class has a SSEKMSKeyId property, which makes it seem like KMS should be supported. The comment for the serverSideEncryption property also mentions aws:kms as an option, however the AWSS3ServerSideEncryption enum only has an entry for AES256. Is there a way with the current SDK to manually set the x-amz-server-side​-encryption header to aws:kms for an upload request?

As a test, I added an entry for KMS to the AWSS3ServerSideEncryption enum, and updated the methods in AWSS3Model.h that return "AES256" when that corresponding enum is set to also return "aws:kms" when the new enum value is set, and I was able to successfully upload using KMS by setting SSEKMSKeyId and using my new enum for serverSideEncryption. So it seems like a pretty simple change to make. Is there a reason why this hasn't been added yet? Should I submit a pull request with my changes?

@bonebox
Copy link
Author

bonebox commented May 2, 2015

Sent pull request #186. We verified a successful KMS server-side encryption for an S3 upload using .serverSideEncryption = AWSS3ServerSideEncryptionKMS and setting valid key for SSEKMSKeyId.

@yosuke-matsuda yosuke-matsuda added the feature-request Request a new feature label May 2, 2015
@yosuke-matsuda
Copy link
Contributor

Thank you for the pull request. We will add the enum in the future release. Thanks.

@bonebox
Copy link
Author

bonebox commented May 4, 2015

Thanks, @yosuke-matsuda! Any ETA on when that will be added?

@bonebox
Copy link
Author

bonebox commented Jul 22, 2015

I noticed this still hasn't been added in the latest release. Are there still plans for this support?

@VarunSurana
Copy link

Hi..Does anyone have an update on when this will be available as a framework which can be included in existing project.

@ghost
Copy link

ghost commented Sep 17, 2015

We've just released AWS Mobile SDK for iOS 2.2.6 which supported KMS server-side encryption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

3 participants