New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullability warnings #882

Merged

lexmakali merged 2 commits into aws-amplify:master from Coeur:nullability

Apr 27, 2018

Contributor

Coeur commented Apr 11, 2018 •

edited

AWSTask.m warning fix:

taskWithResult accepts a nullable result, so initWithResult needs the same nullability specifier.

AWSFMDatabase.m warning fixes:

setCachedStatement:forQuery: calls setObject:forKey:, so the query must be nonnull.
executeUpdate:error:withArgumentsInArray:orDictionary: calls setCachedStatement:forQuery:, so the query must be tested for nil. We return YES because we successfully executed nothing and we didn't set <lastError>, <lastErrorCode>, or <lastErrorMessage> to anything.

AWSLexInteractionKit.m fix:

AWSLexInteractionKit can't be initialized with nil values (because _interactionKitConfig requires to be non null and registerLexWithConfiguration:forKey: requires non null parameter)

Coeur added 2 commits

April 11, 2018 15:23


          Fix nullability warnings

7b8a208


          AWSLexInteractionKit can't be initialized with nil values

91670b0

rohandubal approved these changes

View reviewed changes

lexmakali merged commit 9e885ea into aws-amplify:master

Coeur deleted the nullability branch

April 28, 2018 00:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment