Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose client-level context params on service client configuration #4811

Closed
2 tasks
shiva958 opened this issue Jan 4, 2024 · 3 comments
Closed
2 tasks

Expose client-level context params on service client configuration #4811

shiva958 opened this issue Jan 4, 2024 · 3 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@shiva958
Copy link
Contributor

shiva958 commented Jan 4, 2024

Describe the feature

Currently, while configuring plugins on AWS service clients only service client configuration is passed onto the plugin. However, having access to the client-level context params available as part of service client configuration will simplify and expand the use cases of plugins.

Use Case

As an example, Our team is implementing a plugin that can be attached to the AWS S3 Clients. S3 Clients today support cross-region setting that is only available as part of client-context params. We want our plugin to be able to support cross-region access as well. Since, the plugin does not have access to the client-context params, our approach currently is to have the customers turn-on cross-region setting on the plugin along with the setting on the S3Client. This approach might cause unexpected errors if the customers forgets to turn-on the setting on one of the S3Client or the plugin but not on the other. However, if the plugin has access to the client-context params, we can drop the cross-region setting on the plugin by referencing the configuration on the S3 Client thereby reducing unexpected behaviors.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.22.3

JDK version used

1.8

Operating System and version

MacOS Sonoma 14.2.1

@shiva958 shiva958 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 4, 2024
@debora-ito debora-ito added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jan 4, 2024
@debora-ito
Copy link
Member

@shiva958 thank you for reaching out. We've added a task to our backlog.

@debora-ito
Copy link
Member

Fixed via PR #4834, released in SDK version 2.23.7.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants