Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated client's close() method should not throw checked exceptions #51

Closed
millems opened this issue Jul 6, 2017 · 2 comments
Closed

Generated client's close() method should not throw checked exceptions #51

millems opened this issue Jul 6, 2017 · 2 comments
Assignees
@millems
Labels
1.x Parity feature-request A feature should be added or improved.

Comments

@millems
Copy link
Contributor

millems commented Jul 6, 2017

Generated clients currently inherit their close() method from AutoCloseable, which currently declares that it throws Exception. In actuality, checked exceptions will never be throw. The client interfaces should override the close() method to remove the throws statement.
@millems millems self-assigned this Aug 7, 2017
@millems
Copy link
Contributor Author

millems commented Aug 7, 2017 •
edited
Loading

PR to fix: #99

@shorea
Copy link
Contributor

shorea commented Jun 15, 2018

Implemented

@shorea shorea closed this as completed Jun 15, 2018
@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millems millems

Labels
1.x Parity feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shorea @millems @justnance