Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't download 200MB of JS for a JavaDoc search feature that most people don't use #5274

Open
1 task done
michaelboyles opened this issue Jun 7, 2024 · 1 comment
Open
1 task done
Labels
documentation This is a problem with documentation.

Comments

@michaelboyles
Copy link

Upcoming End-of-Support

  • I acknowledge the upcoming end-of-support for AWS SDK for Java v1 was announced, and migration to AWS SDK for Java v2 is recommended.

Describe the issue

When visiting https://sdk.amazonaws.com/java/api/2.25.67/software/amazon/awssdk/regions/providers/DefaultAwsRegionProviderChain.html

I observed that the loading spinner on the tab seemingly spun forever. After looking at the network tab, I saw it was downloading this: https://sdk.amazonaws.com/java/api/2.25.67/member-search-index.js

It's 216MB of JS... I'm pretty sure this file is generated by the default JavaDoc tool. It's a search index which I think is only useful when using the top-right search box, which I never use anyway.

I don't know whether Chrome refuses to cache it because it's so massive, or cache headers are not set properly, but every single page requests it from scratch.

The type search at https://sdk.amazonaws.com/java/api/2.25.67/type-search-index.js is also 17MB which is less horrendous, and at least that one gets cached, but that is still too much to download.

For now, I blocked this URL https://sdk.amazonaws.com/*search-index.js in my ad blocker

Links

https://sdk.amazonaws.com/java/api/2.25.67/software/amazon/awssdk/regions/providers/DefaultAwsRegionProviderChain.html

As well as every single page

@michaelboyles michaelboyles added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jun 7, 2024
@debora-ito
Copy link
Member

@michaelboyles thank you for raising this. 200+ MB surely is a lot to be downloaded in every page.

Moving this to the Java SDK v2 repo.

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Jun 8, 2024
@debora-ito debora-ito transferred this issue from aws/aws-sdk-java Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

No branches or pull requests

2 participants