Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jackson-databind dependency #3091

Closed
2 tasks
cpg-dana-mckiernan opened this issue Feb 2, 2024 · 2 comments
Closed
2 tasks

Update jackson-databind dependency #3091

cpg-dana-mckiernan opened this issue Feb 2, 2024 · 2 comments
Labels
closed-for-staleness feature-request A feature should be added or improved.

Comments

@cpg-dana-mckiernan
Copy link

Describe the feature

The symbol PropertyNamingStrategy PASCAL_CASE_TO_CAMEL_CASE from jackson-databind was removed in their release v1.16.0. It still appears in the aws-sdk-java-core source code for the EC2MetadataUtils class here:

https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-core/src/main/java/com/amazonaws/util/EC2MetadataUtils.java#L98

This causes your code, when used with a newer library, to throw NoClassDefFoundError exceptions, and fail to initialize

Use Case

Using aws-sdk-java-core versions up through v1.12.650 with any version of jackson-databind v2.16.0 or newer causes applications to not run and initialization exceptions to get thrown.

Proposed Solution

Update your code, or call out explicitly that this library requires versions of jackson-databind older thanv2.16.0.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

1.12.650

JDK version used

openjdk version "17.0.7" 2023-04-18 OpenJDK Runtime Environment Temurin-17.0.7+7 (build 17.0.7+7) OpenJDK 64-Bit Server VM Temurin-17.0.7+7 (build 17.0.7+7, mixed mode, sharing)

Operating System and version

Red Hat Enterprise Linux Server 7.9 (Maipo)

@cpg-dana-mckiernan cpg-dana-mckiernan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 2, 2024
@debora-ito
Copy link
Member

We are aware of this issue.

The plan is to update the code, there's some level of development happening now, but we don't have a timeline for when it will be finished. I'll add a comment here when we have an update.

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Feb 7, 2024
@debora-ito
Copy link
Member

EC2MetadatUtils will now check for PropertyNamingStrategies.UPPER_CAMEL_CASE first, and if it's not present it will check for properties of the older versions of jackson.

The change was released in version 1.12.655.

@debora-ito debora-ito added the closing-soon This issue will close in 2 days unless further comments are made. label Feb 13, 2024
@github-actions github-actions bot added closed-for-staleness and removed closing-soon This issue will close in 2 days unless further comments are made. labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants