Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK Metrics not reporting HttpClientPoolAvailableCount or HttpClientPoolPendingCount #3099

Closed
1 task done
AndrewMacKenzieFD opened this issue Mar 4, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug. closed-for-staleness response-requested Waiting on additional info or feedback. Will move to "closing-soon" in 5 days.

Comments

@AndrewMacKenzieFD
Copy link

Upcoming End-of-Support

  • I acknowledge the upcoming end-of-support for AWS SDK for Java v1 was announced, and migration to AWS SDK for Java v2 is recommended.

Describe the bug

version 1.11.804

aws-sdk-core - AwsSdkMetrics

We are attempting to use this package in order to monitor our SNS connection pools, during testing we have observed that both HttpClientPoolAvailableCount & HttpClientPoolPendingCount are not being reported when making requests, but HttpClientPoolLeasedCount is.

We have implemented our own RequestMetricCollector with additional logging and can confirm that there are no instances of the aforementioned metrics as part of the AWSRequestMetrics object on the requests in question from both SNS and SQS.

Expected Behavior

We would expect these metrics to be produced.

Current Behavior

The metrics HttpClientPoolAvailableCount & HttpClientPoolPendingCount are not being reported as part of the Request inside the AWSRequestMetrics object during any SNS or SQS operation.

Reproduction Steps

  1. AwsSdkMetrics enabled for application
  2. SNS sync client created, using NotificationMessagingTemplate to publish messages

Possible Solution

No response

Additional Information/Context

No response

AWS Java SDK version used

1.11.804

JDK version used

17

Operating System and version

docker - eclipse-temurin:17-alpine

@AndrewMacKenzieFD AndrewMacKenzieFD added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2024
@debora-ito
Copy link
Member

@AndrewMacKenzieFD there's no obvious reasons why the SDK would not obtain HttpClientPoolAvailableCount
or HttpClientPoolPendingCount, specially because the three metrics are captured at the same time:

awsRequestMetrics
.withCounter(HttpClientPoolAvailableCount, stats.getAvailable())
.withCounter(HttpClientPoolLeasedCount, stats.getLeased())
.withCounter(HttpClientPoolPendingCount, stats.getPending());

Is this something reproducible?
Is it intermittent or it happens every time?

JDK 17 is not supported in the Java SDK v1, this could be related but I'm not sure. Could you test with JDK <= 16?

@debora-ito debora-ito added response-requested Waiting on additional info or feedback. Will move to "closing-soon" in 5 days. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 29, 2024
@debora-ito debora-ito self-assigned this Mar 29, 2024
Copy link

github-actions bot commented Apr 8, 2024

It looks like this issue has not been active for more than five days. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please add a comment to prevent automatic closure, or if the issue is already closed please feel free to reopen it.

@github-actions github-actions bot added closing-soon This issue will close in 2 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will close in 2 days unless further comments are made. labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. closed-for-staleness response-requested Waiting on additional info or feedback. Will move to "closing-soon" in 5 days.
Projects
None yet
Development

No branches or pull requests

2 participants