Check if parameters are passed during DocumentClient creation (#547)

aws · Aug 4, 2023 · 56ac51a · 56ac51a
1 parent 432133e
commit 56ac51a
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 15 deletions.
diff --git a/.changeset/quiet-cherries-tell.md b/.changeset/quiet-cherries-tell.md
@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Check if parameters are passed during DocumentClient creation
diff --git a/src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-none.input.js b/src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-none.input.js
@@ -0,0 +1,3 @@
+import AWS from "aws-sdk";
+
+const documentClient = new AWS.DynamoDB.DocumentClient();
diff --git a/src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-none.output.js b/src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-none.output.js
@@ -0,0 +1,4 @@
+import { DynamoDBDocument } from "@aws-sdk/lib-dynamodb";
+import { DynamoDB } from "@aws-sdk/client-dynamodb";
+
+const documentClient = DynamoDBDocument.from(new DynamoDB());
diff --git a/src/transforms/v2-to-v3/client-instances/getDynamoDBDocClientArgs.ts b/src/transforms/v2-to-v3/client-instances/getDynamoDBDocClientArgs.ts
@@ -15,7 +15,7 @@ export const getDynamoDBDocClientArgs = (
 
   const v2DocClientArgs = v2DocClientNewExpression.node.arguments || [];
 
-  // Add DocumentClient option convertEmptyValues.
+  // Add DocumentClient option convertEmptyValues/wrapNumbers.
   if (v2DocClientArgs.length > 0) {
     const params = v2DocClientArgs[0];
     if (params.type === "ObjectExpression") {

diff --git a/src/transforms/v2-to-v3/client-instances/getDynamoDBForDocClient.ts b/src/transforms/v2-to-v3/client-instances/getDynamoDBForDocClient.ts
@@ -42,23 +42,25 @@ export const getDynamoDBForDocClient = (
   const v3DocClientNewExpressionArgs = [];
 
   // Remove DocumentClient option convertEmptyValues and wrapNumbers.
-  if (v3DocClientArgs.type === "ObjectExpression") {
-    v3DocClientArgs.properties = v3DocClientArgs.properties.filter((property) => {
-      if (!OBJECT_PROPERTY_TYPE_LIST.includes(property.type)) {
-        return true;
-      }
-      const propertyKey = (property as Property | ObjectProperty).key;
-      if (propertyKey.type !== "Identifier") {
-        return true;
-      }
-      return !["convertEmptyValues", "wrapNumbers"].includes(propertyKey.name);
-    });
+  if (v3DocClientArgs) {
+    if (v3DocClientArgs.type === "ObjectExpression") {
+      v3DocClientArgs.properties = v3DocClientArgs.properties.filter((property) => {
+        if (!OBJECT_PROPERTY_TYPE_LIST.includes(property.type)) {
+          return true;
+        }
+        const propertyKey = (property as Property | ObjectProperty).key;
+        if (propertyKey.type !== "Identifier") {
+          return true;
+        }
+        return !["convertEmptyValues", "wrapNumbers"].includes(propertyKey.name);
+      });
 
-    if (v3DocClientArgs.properties.length > 0) {
+      if (v3DocClientArgs.properties.length > 0) {
+        v3DocClientNewExpressionArgs.push(v3DocClientArgs);
+      }
+    } else {
       v3DocClientNewExpressionArgs.push(v3DocClientArgs);
     }
-  } else {
-    v3DocClientNewExpressionArgs.push(v3DocClientArgs);
   }
 
   return j.newExpression(