Create new object instead of modifying existing expression (#228)

aws · Dec 27, 2022 · d3f130c · d3f130c
1 parent 27a2f24
commit d3f130c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/.changeset/great-walls-begin.md b/.changeset/great-walls-begin.md
@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Create new object instead of modifying existing expression
diff --git a/src/transforms/v2-to-v3/utils/replace/replaceClientCreation.ts b/src/transforms/v2-to-v3/utils/replace/replaceClientCreation.ts
@@ -17,18 +17,14 @@ export const replaceClientCreation = (
   // Replace clients created with default module.
   source
     .find(j.NewExpression, getV2ClientNewExpression({ v2DefaultModuleName, v2ClientName }))
-    .replaceWith((nodePath) => {
-      const { node } = nodePath;
-      node.callee = j.identifier(v3ClientName);
-      return node;
-    });
+    .replaceWith((v2ClientNewExpression) =>
+      j.newExpression(j.identifier(v3ClientName), v2ClientNewExpression.node.arguments)
+    );
 
   // Replace clients created with client module.
   source
     .find(j.NewExpression, getV2ClientNewExpression({ v2ClientName }))
-    .replaceWith((nodePath) => {
-      const { node } = nodePath;
-      node.callee = j.identifier(v3ClientName);
-      return node;
-    });
+    .replaceWith((v2ClientNewExpression) =>
+      j.newExpression(j.identifier(v3ClientName), v2ClientNewExpression.node.arguments)
+    );
 };
diff --git a/src/transforms/v2-to-v3/utils/replace/replaceTSTypeReference.ts b/src/transforms/v2-to-v3/utils/replace/replaceTSTypeReference.ts
@@ -51,11 +51,9 @@ export const replaceTSTypeReference = (
         right: { type: "Identifier", name: v2ClientName },
       },
     })
-    .replaceWith((tsTypeRef) => {
-      const { node } = tsTypeRef;
-      node.typeName = j.identifier(v3ClientName);
-      return node;
-    });
+    .replaceWith((v2ClientType) =>
+      j.tsTypeReference(j.identifier(v3ClientName), v2ClientType.node.typeParameters)
+    );
 
   // Replace type reference to client input/output created with default module.
   source