Support removal of .promise() with parentPath ObjectProperty (#392)

aws · Feb 22, 2023 · ec4577c · ec4577c
1 parent 387473f
commit ec4577c
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 0 deletions.
diff --git a/.changeset/stale-tigers-call.md b/.changeset/stale-tigers-call.md
@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Support removal of .promise() with parentPath ObjectProperty
diff --git a/src/transforms/v2-to-v3/__fixtures__/api-promise/global-import.input.ts b/src/transforms/v2-to-v3/__fixtures__/api-promise/global-import.input.ts
@@ -1,5 +1,9 @@
 import AWS from "aws-sdk";
 
+export const listTablesObjectProperty = async (client: AWS.DynamoDB) => ({
+  promise: client.listTables().promise(),
+});
+
 export const listTables = async (client: AWS.DynamoDB) => client.listTables().promise();
 export const listTagsOfResource = async (client: AWS.DynamoDB) =>
   client.listTagsOfResource({ ResourceArn: "STRING_VALUE" }).promise();

diff --git a/src/transforms/v2-to-v3/__fixtures__/api-promise/global-import.output.ts b/src/transforms/v2-to-v3/__fixtures__/api-promise/global-import.output.ts
@@ -1,5 +1,9 @@
 import { DynamoDB } from "@aws-sdk/client-dynamodb";
 
+export const listTablesObjectProperty = async (client: DynamoDB) => ({
+  promise: client.listTables(),
+});
+
 export const listTables = async (client: DynamoDB) => client.listTables();
 export const listTagsOfResource = async (client: DynamoDB) =>
   client.listTagsOfResource({ ResourceArn: "STRING_VALUE" });

diff --git a/src/transforms/v2-to-v3/__fixtures__/api-promise/service-import.input.ts b/src/transforms/v2-to-v3/__fixtures__/api-promise/service-import.input.ts
@@ -1,5 +1,9 @@
 import DynamoDB from "aws-sdk/clients/dynamodb";
 
+export const listTablesObjectProperty = async (client: DynamoDB) => ({
+  promise: client.listTables().promise(),
+});
+
 export const listTables = async (client: DynamoDB) => client.listTables().promise();
 export const listTagsOfResource = async (client: DynamoDB) =>
   client.listTagsOfResource({ ResourceArn: "STRING_VALUE" }).promise();

diff --git a/src/transforms/v2-to-v3/__fixtures__/api-promise/service-import.output.ts b/src/transforms/v2-to-v3/__fixtures__/api-promise/service-import.output.ts
@@ -1,5 +1,9 @@
 import { DynamoDB } from "@aws-sdk/client-dynamodb";
 
+export const listTablesObjectProperty = async (client: DynamoDB) => ({
+  promise: client.listTables(),
+});
+
 export const listTables = async (client: DynamoDB) => client.listTables();
 export const listTagsOfResource = async (client: DynamoDB) =>
   client.listTagsOfResource({ ResourceArn: "STRING_VALUE" });

diff --git a/src/transforms/v2-to-v3/apis/removePromiseForCallExpression.ts b/src/transforms/v2-to-v3/apis/removePromiseForCallExpression.ts
@@ -22,6 +22,7 @@ export const removePromiseForCallExpression = (callExpression: ASTPath<CallExpre
       break;
     }
     case "ArrowFunctionExpression":
+    case "ObjectProperty":
     case "ReturnStatement": {
       const currentCalleeObject = (callExpression.value.callee as MemberExpression)
         .object as CallExpression;