update Hash implementations with Checksum interface #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
force-pushed
the
master
branch
from
80f7d3c
to
678563e
Compare
AndrewFossAWS
commented
Dec 12, 2022
| import { Hash as SdkNodeHash } from "@aws-sdk/hash-node"; | ||
|
|
||
| // TODO: remove the following when SdkNodeHash has implemented Checksum interface in aws-sdk-js-v3 | ||
| export class NodeHash implements Checksum { |
There was a problem hiding this comment.
There is circular dependency between the aws-sdk-js-crypto-helpers and aws-js-sdk-v3.
@aws-sdk/hash-node's Hash implementation needs to be updated to use Checksum interface after this PR is merged, then this class will be removed afterwards.
AndrewFossAWS
force-pushed
the
master
branch
from
678563e
to
295e06c
Compare
texastony
requested changes
Jan 6, 2023
There was a problem hiding this comment.
I have some code style suggestions.
Otherwise, I have two blocking questions.
- Does a circular dependency already exist? If not, I would like to avoid it.
- I am generally against creating a field that holds priveldged information unless strictly neccesary. For the
shapackages, I think it may be possible to avoid creating thesecretfield and still implementreset. It may even be possible to avoid repeat code...
I am requesting changes for the test imports.
Have you tried abstracting the reset and constructor logic
in the Sha packages such that we can avoid secret and repeat code?
Yes the circular dependency has already existed prior to this change. |
AndrewFossAWS
force-pushed
the
master
branch
3 times, most recently
from
ea507d6
to
4ecc4ee
Compare
texastony
previously requested changes
Jan 9, 2023
texastony
dismissed
their stale review
All blockiing issues have been resolved
texastony
previously approved these changes
Jan 10, 2023
texastony
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related issue #485
This PR updates Hash implementations with Checksum interface.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.