fix: parseurl in Node returns only pathname when protocol not specifi…

…ed (#566)
aws · Jan 3, 2020 · 0454dd6 · 0454dd6
1 parent 272ae8d
commit 0454dd6
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/config-resolver/src/EndpointsConfig.ts b/packages/config-resolver/src/EndpointsConfig.ts
@@ -43,18 +43,20 @@ export interface EndpointsResolvedConfig
 export function resolveEndpointsConfig<T>(
   input: T & EndpointsInputConfig & PreviouslyResolved
 ): T & EndpointsResolvedConfig {
-  const tls = input.tls || true;
+  const tls = input.tls === undefined ? true : input.tls;
   const endpoint: Provider<Endpoint> = input.endpoint
     ? normalizeEndpoint(input.endpoint, input.urlParser)
     : () =>
         input.region().then(async region => {
           const hostname = (
             (await input.regionInfoProvider(region)) || ({} as RegionInfo)
           ).hostname;
-          if (!hostname)
+          if (!hostname) {
             throw new Error("Cannot resolve hostname from client config");
-          const endpoint = input.urlParser(hostname);
-          endpoint.protocol = tls ? "https:" : "http:";
+          }
+          const endpoint = input.urlParser(
+            `${tls ? "https:" : "http:"}//${hostname}`
+          );
           return endpoint;
         });
   return {