Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor nodejs region loader #1437

Merged
merged 4 commits into from Aug 14, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Description of changes:
Use @aws-sdk/node-config-provider package to load region in Nodejs. This change eliminates @aws-sdk/region-provider package. The purpose of this change is to consolidate all the server-side configuration loading, from config files, environment variables, and default valiues, to a single package.

The last commit is code generation. You can review the previous commits only for actual changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #1437 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1437      +/-   ##
==========================================
+ Coverage   79.08%   79.67%   +0.59%     
==========================================
  Files         287      299      +12     
  Lines       11155    11391     +236     
  Branches     2360     2431      +71     
==========================================
+ Hits         8822     9076     +254     
+ Misses       2333     2315      -18     
Impacted Files Coverage Δ
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/util-create-request/src/index.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 66.94% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/middleware-signing/src/middleware.ts 91.66% <0.00%> (ø)
protocol_tests/aws-query/protocols/Aws_query.ts 66.72% <0.00%> (ø)
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 66.25% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e600e...d0b0f8c. Read the comment docs.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants