Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-s3): use regional endpoint by default and support aws-global region #1552

Merged
merged 3 commits into from Oct 7, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Description of changes:
In S3 client, when using us-east-1 region, then endpoint will be resolved to global endpoint s3.amazonaws.com. This customization makes sure the request is made to regional endpoint s3.us-east-1.amazonaws.com by default. If the endpoint is supplied by user explicitly, SDK won't modify the endpoint to regional.

When using aws-global region explicitly, now S3 will resolve the request to global endpoint s3.amazonaws.com.

This PR is blocked by #1551

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review October 7, 2020 00:47
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #1552 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1552      +/-   ##
==========================================
+ Coverage   79.84%   80.01%   +0.17%     
==========================================
  Files         304      307       +3     
  Lines       11753    11863     +110     
  Branches     2511     2545      +34     
==========================================
+ Hits         9384     9492     +108     
- Misses       2369     2371       +2     
Impacted Files Coverage Δ
...dleware-bucket-endpoint/src/bucketHostnameUtils.ts 96.47% <0.00%> (-1.87%) ⬇️
packages/middleware-host-header/src/index.ts 80.00% <0.00%> (ø)
packages/config-resolver/src/EndpointsConfig.ts 100.00% <0.00%> (ø)
packages/middleware-bucket-endpoint/src/index.ts 100.00% <0.00%> (ø)
packages/util-dynamodb/src/convertToNative.ts 100.00% <0.00%> (ø)
...ges/middleware-sdk-s3/src/use-regional-endpoint.ts 86.66% <0.00%> (ø)
packages/util-dynamodb/src/unmarshall.ts 100.00% <0.00%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 91.89% <0.00%> (+0.22%) ⬆️
...s/middleware-bucket-endpoint/src/bucketHostname.ts 100.00% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e1fc4...74b714c. Read the comment docs.

Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
@AllanZhengYP AllanZhengYP merged commit 47c6599 into aws:master Oct 7, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants