New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s3-control): support S3 Outposts control plane #1553
Conversation
…ization Remove the host prefix customziation because with new S3 control model, the host prefix is modeled. So no customization is needed.
Codecov Report
@@ Coverage Diff @@
## master #1553 +/- ##
=========================================
Coverage ? 80.14%
=========================================
Files ? 311
Lines ? 11934
Branches ? 2555
=========================================
Hits ? 9564
Misses ? 2370
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
packages/middleware-sdk-s3-control/src/process-arnables-plugin/update-arnables-request.ts
Outdated
Show resolved
Hide resolved
packages/middleware-sdk-s3-control/src/process-arnables-plugin/parse-outpost-arnables.ts
Show resolved
Hide resolved
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description of changes:
Add support to S3 Outpost endpoints and related new resources ARNs. All touched operations has been tested against prod endpoint.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.