Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-http-handler): fix type error sending Uint8Array as payload #1561

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Oct 12, 2020

Resolves #1433

Description of changes:
Root cause is mentioned here: #1433 (comment). This change converts non streaming binary data(string, Uint8Array, ArrayBuffer, ArrayBufferView) into a buffer before sending on the wire.

This change also move commented https unit tetss to http test to increase some test coverage.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #1561 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
+ Coverage   79.84%   80.22%   +0.38%     
==========================================
  Files         304      313       +9     
  Lines       11753    11965     +212     
  Branches     2511     2564      +53     
==========================================
+ Hits         9384     9599     +215     
+ Misses       2369     2366       -3     
Impacted Files Coverage Δ
...dleware-bucket-endpoint/src/bucketHostnameUtils.ts 96.47% <0.00%> (-1.87%) ⬇️
packages/middleware-host-header/src/index.ts 80.00% <0.00%> (ø)
packages/config-resolver/src/EndpointsConfig.ts 100.00% <0.00%> (ø)
packages/middleware-bucket-endpoint/src/index.ts 100.00% <0.00%> (ø)
packages/util-hex-encoding/dist/cjs/src/index.ts
...ist/cjs/remoteProvider/src/remoteProvider/retry.ts
.../credential-provider-process/dist/cjs/src/index.ts
...rovider-imds/dist/cjs/src/fromContainerMetadata.ts
...ages/credential-provider-env/dist/cjs/src/index.ts
packages/is-array-buffer/dist/cjs/src/index.ts
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdec42...8a55ec2. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 7bf03fc into aws:master Oct 13, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda InvokeCommand payload with UInt8Array type
3 participants