Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3-presigned-post): support S3 object post #1642

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Oct 29, 2020

Add support for generating presigned post url and fields. Users can use them to upload file without AWS credentials.

This package is on parity with s3.createPresignedPost() in v2

Resolves: #395

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #1642 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
+ Coverage   79.77%   79.84%   +0.06%     
==========================================
  Files         325      327       +2     
  Lines       12087    12127      +40     
  Branches     2553     2558       +5     
==========================================
+ Hits         9643     9683      +40     
  Misses       2444     2444              
Impacted Files Coverage Δ
packages/s3-presigned-post/src/constants.ts 100.00% <100.00%> (ø)
...kages/s3-presigned-post/src/createPresignedPost.ts 100.00% <100.00%> (ø)
packages/util-format-url/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7aa08...d1dfbc3. Read the comment docs.

packages/s3-presigned-post/README.md Outdated Show resolved Hide resolved
packages/s3-presigned-post/README.md Outdated Show resolved Hide resolved
packages/s3-presigned-post/README.md Outdated Show resolved Hide resolved
packages/s3-presigned-post/src/createPresignedPost.ts Outdated Show resolved Hide resolved
packages/s3-presigned-post/src/createPresignedPost.ts Outdated Show resolved Hide resolved
packages/s3-presigned-post/src/createPresignedPost.ts Outdated Show resolved Hide resolved
packages/s3-presigned-post/src/createPresignedPost.ts Outdated Show resolved Hide resolved
packages/s3-presigned-post/src/createPresignedPost.ts Outdated Show resolved Hide resolved
@AllanZhengYP
Copy link
Contributor Author

Addressed the documenting & formatting feedbacks in 5f45ba0, with some other changes in README.

@AllanZhengYP AllanZhengYP merged commit 5fb8918 into aws:master Oct 30, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analog to createPresignedPost from v2?
3 participants