fix(middleware-sdk-sqs): Fix MD5 verification on SendMessageBatch. #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexforsyth
approved these changes
Nov 16, 2020
|
@alexforsyth When it is planned to be merged? Thanks! |
|
My bad! Forgot to hit merge. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in there
This PR fixes a bug in SendMessageBatch that make MD5 verifications against the hashes returned by AWS always fail.
## Note to maintainers
The test suite for this file mocks the MD5 factory, making this error non catchable and the test useless.
Legal
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.