Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): import SENSITIVE_STRING only when used #1761

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 10, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#244

Description of changes:
import SENSITIVE_STRING only when used

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr changed the title fix: import SENSITIVE_STRING only when used fix(codegen): import SENSITIVE_STRING only when used Dec 10, 2020
@trivikr trivikr merged commit 9296283 into aws:master Dec 10, 2020
@trivikr trivikr deleted the import-SENSITIVE_STRING-only-when-needed branch December 10, 2020 16:57
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants