Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credential-provider-node): use credential_process from profile #1773

Merged
merged 2 commits into from
Dec 19, 2020

Conversation

christophgysin
Copy link
Contributor

fixes #1772

Issue #, if available:
#1772

Description of changes:
Consider credential_process defined in profile passed in AWS_PROFILE

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #1773 (df16cf3) into master (de75f7e) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1773      +/-   ##
==========================================
+ Coverage   79.77%   79.83%   +0.05%     
==========================================
  Files         325      336      +11     
  Lines       12087    12623     +536     
  Branches     2553     2680     +127     
==========================================
+ Hits         9643    10078     +435     
- Misses       2444     2545     +101     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a6f5c...df16cf3. Read the comment docs.

@AllanZhengYP
Copy link
Contributor

@christophgysin Thanks a lot for the fix. I believe it will fix the issue perfectly. Can you add a unit test for the behavior just like this one?

@christophgysin
Copy link
Contributor Author

@AllanZhengYP I added a unit test for the change, let me know if there is anything else needed to get this fixed!

@AllanZhengYP AllanZhengYP merged commit 842e2a0 into aws:master Dec 19, 2020
@AllanZhengYP
Copy link
Contributor

@christophgysin 🚀🚀🚀 Merged! Thank you for the contribution!

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS_PROFILE won't honor credentials_process in configuration
3 participants