Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util-waiter): fix compiling error with waiter #1812

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Fixes #1803

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Dec 20, 2020

Codecov Report

Merging #1812 (dbd01e1) into master (dd04fa3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1812   +/-   ##
=======================================
  Coverage   79.30%   79.31%           
=======================================
  Files         368      368           
  Lines       15132    15129    -3     
  Branches     3222     3222           
=======================================
- Hits        12001    12000    -1     
+ Misses       3131     3129    -2     
Impacted Files Coverage Δ
packages/util-waiter/src/waiter.ts 100.00% <ø> (ø)
protocol_tests/aws-ec2/endpoints.ts 81.48% <ø> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <ø> (ø)
protocol_tests/aws-query/endpoints.ts 81.48% <ø> (ø)
protocol_tests/aws-restjson/endpoints.ts 81.48% <ø> (ø)
protocol_tests/aws-restxml/endpoints.ts 81.48% <ø> (ø)
packages/util-waiter/src/createWaiter.ts 100.00% <100.00%> (+11.76%) ⬆️
packages/util-waiter/src/poller.ts 100.00% <100.00%> (ø)
packages/util-waiter/src/utils/validate.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d2210...dbd01e1. Read the comment docs.

Remove the type guard to unblock aws#1803.
TODO: add type guard that doesn't block the compile
@AllanZhengYP AllanZhengYP marked this pull request as ready for review December 23, 2020 18:49
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, lgtm

@AllanZhengYP AllanZhengYP merged commit ca1f0d6 into aws:master Dec 23, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type 'DynamoDBClient' does not satisfy the constraint 'SmithyClient'.
4 participants