Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util-dynamodb): state options.wrapNumbers on BigInt error in unmarshall #2015

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 10, 2021

Issue

Fixes: #2014

Description

Error states options.wrapNumbers when BigInt throws in unmarshall

Testing

Unit tests


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #2015 (b3e017d) into master (f2a47e8) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2015      +/-   ##
==========================================
+ Coverage   79.30%   79.35%   +0.04%     
==========================================
  Files         368      368              
  Lines       15132    15197      +65     
  Branches     3222     3254      +32     
==========================================
+ Hits        12001    12060      +59     
- Misses       3131     3137       +6     
Impacted Files Coverage Δ
packages/util-waiter/src/utils/validate.ts 81.81% <0.00%> (-18.19%) ⬇️
...process-arnables-plugin/update-arnables-request.ts 91.30% <0.00%> (-8.70%) ⬇️
lib/storage/src/data-chunk/readable-helper.ts 86.84% <0.00%> (-5.47%) ⬇️
packages/s3-request-presigner/src/presigner.ts 94.73% <0.00%> (-5.27%) ⬇️
...s/middleware-bucket-endpoint/src/bucketHostname.ts 98.27% <0.00%> (-1.73%) ⬇️
packages/util-dynamodb/src/convertToAttr.ts 98.82% <0.00%> (-1.18%) ⬇️
packages/util-waiter/src/poller.ts 100.00% <0.00%> (ø)
packages/util-waiter/src/waiter.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9a469...b3e017d. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: b3e017d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr changed the title fix(util-dynamodb): state options.wrapNumbers when BigInt throws in unmarshall fix(util-dynamodb): state options.wrapNumbers on BigInt error in unmarshall Feb 10, 2021
@trivikr trivikr merged commit d1c548e into aws:master Feb 10, 2021
@trivikr trivikr deleted the update-message-BigInt-throw branch February 10, 2021 19:21
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[util-dynamodb] "Uncaught SyntaxError" on unmarshalling floating point numbers outside SAFE_INTEGER bounds
4 participants