fix(codegen): move auth to standalone plugin #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
fix-default-auth-provider
branch
from
a8a9615
to
24e9249
Compare
Codecov Report
@@ Coverage Diff @@
## main #2076 +/- ##
=======================================
Coverage ? 79.45%
=======================================
Files ? 366
Lines ? 15324
Branches ? 3310
=======================================
Hits ? 12176
Misses ? 3148
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
approved these changes
Feb 25, 2021
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Outdated
Show resolved
Hide resolved
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Outdated
Show resolved
Hide resolved
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Outdated
Show resolved
Hide resolved
AllanZhengYP
force-pushed
the
fix-default-auth-provider
branch
from
24e9249
to
8646a34
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an AWS Auth plugin in generator to consolidate all the auth related customizations. As a result, if a service as
optionalAuthfor all the operations, no auth related dependencies will be pulled in to generated package.Testing
It has been manually tested with S3 and SSO clients
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.