Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): pin fast-xml-parser to v3.17.4 #2102

Merged
merged 3 commits into from Mar 4, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 4, 2021

Issue

N/A

Description

Pinning fast-xml-parser to v3.17.4 as the project switched to modified MIT License in >=v3.17.5 in NaturalIntelligence/fast-xml-parser@5d4e951

Testing

CI. Integration tests.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@e352a13). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2102   +/-   ##
=======================================
  Coverage        ?   78.65%           
=======================================
  Files           ?      378           
  Lines           ?    16024           
  Branches        ?     3430           
=======================================
  Hits            ?    12603           
  Misses          ?     3421           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e352a13...99879a3. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexforsyth
Copy link
Contributor

@trivikr why is codegen CI failing?

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 after fixing the CI failure

@trivikr
Copy link
Member Author

trivikr commented Mar 4, 2021

@trivikr why is codegen CI failing?

The CI was failing as the update on smithy-typescript wasn't updated smithy-lang/smithy-typescript#280
It's merged now, and CI should succeed.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 36c954b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit c612c75 into aws:main Mar 4, 2021
@trivikr trivikr deleted the pin-fast-xml-parser branch March 4, 2021 19:48
@monken
Copy link

monken commented Mar 7, 2021

@trivikr looks like they just removed the modifications: NaturalIntelligence/fast-xml-parser@1357c5d

@G-Rath
Copy link

G-Rath commented Mar 8, 2021

indeed - @amitguptagwl moved the library back to using standard MIT to allow aws-sdk to use the library without having to pin the version constraint after I mentioned this pinning on my PR🎉

(thanks @amitguptagwl for that ❤️).

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants