-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clients): adding throwable waiters WaitUntil[operationState] #2302
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2302 +/- ##
=======================================
Coverage ? 60.02%
=======================================
Files ? 472
Lines ? 24847
Branches ? 5885
=======================================
Hits ? 14915
Misses ? 9932
Partials ? 0 Continue to review full report at Codecov.
|
This PR needs rebase @alexforsyth |
62cd2ff
to
67c1e7d
Compare
All the SDK related interfaces should be exported from |
/** | ||
* @deprecated Use abortSignal | ||
* Abort controller. Used for ending the waiter early. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove documentation, as we're now recommending customers to use abortSignal
.
/** | |
* @deprecated Use abortSignal | |
* Abort controller. Used for ending the waiter early. | |
*/ | |
/** | |
* @deprecated Use `abortSignal` instead. | |
*/ |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
#1917
Issue number, if available, prefixed with "#"
Description
WaitUntilBlahBlah
that throws when a waiter enters a non-success stateWaitForBlahBlah
since it doesn't throw.What does this implement/fix? Explain your changes.
Testing
How was this change tested?
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.