feat(codegen): add user agent for non AWS clients #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2415 +/- ##
=======================================
Coverage ? 59.08%
=======================================
Files ? 490
Lines ? 26204
Branches ? 6224
=======================================
Hits ? 15482
Misses ? 10722
Partials ? 0 Continue to review full report at Codecov.
|
JordonPhillips
approved these changes
May 25, 2021
AllanZhengYP
approved these changes
Jun 3, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had disabled user agent plugin for non AWS clients earlier as it depended on serviceId which is not present for non AWS services. This enables it back. serviceId is optional, so omitting it for non AWS services.
Testing
Added unit tests.
Generated client for non AWS service in demo package and looked at headers sent to the service by this client and compared with AWS service's client.
Demo service client:
where 1.0.0-rc.1 is the version of generated client in its package.json.
AWS service client (used AccessAnalyzerClient):
I assume for browser client, the
user-agentheader would not be there but thex-amz-user-agentwould be.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.