feat(client-s3): add md5 header for operations with httpChecksumRequired trait #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2507 +/- ##
=======================================
Coverage ? 59.54%
=======================================
Files ? 494
Lines ? 26403
Branches ? 6269
=======================================
Hits ? 15721
Misses ? 10682
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
approved these changes
Jun 23, 2021
…oad" This reverts commit d72211c40d2d449b8b3f1988df7635a7f4b04cc1.
…o sqs customization
…sumRequired trait
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously S3 and S3Control has customization that adding the stream hashing and the md5 dependencies to certain allow-listed operations. In this change, we remove there customizations, and rely on the
httpChecksumRequiredSmithy trait to generate these dependencies. The old MD5 customization is renamed to SQS customization because it only handles SQS requirement to have the MD5 dependency.Testing
Unit-test and manual test on S3, S3Control, and SQS
Additional context
Related to smithy-lang/smithy-typescript#363
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.