Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postinstall-node-version-check): util to show NodeDeprecationWarning #2585

Merged
merged 6 commits into from
Jul 16, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 16, 2021

Issue

Internal JS-2727

Description

Creates a script which can be run on postinstall
The script displays the following message if Node.js version is <12.0.0

(node:11997) NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
no longer support Node.js v10.24.1 as of January 1, 2022.
To continue receiving updates to AWS services, bug fixes, and security
updates please upgrade to Node.js 12.x or later.

More information can be found at: {LINK TO BLOG}

Testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c2e88a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2585   +/-   ##
=======================================
  Coverage        ?   60.32%           
=======================================
  Files           ?      515           
  Lines           ?    27382           
  Branches        ?     6583           
=======================================
  Hits            ?    16517           
  Misses          ?    10865           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e88a4...b184aa7. Read the comment docs.

The CI is failing because of the check, and it's not required
as Node.js 6.x is way older than currently supported >=10.x
The blog post will be live when next version is released.
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: fcd0261
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 08c0342 into aws:main Jul 16, 2021
@trivikr trivikr deleted the postinstall-node-version-check branch July 16, 2021 17:34
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants