Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-sdk-transcribe-streaming): validate signer #2676

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

markbrouch
Copy link
Contributor

@markbrouch markbrouch commented Aug 14, 2021

This fixes a bug in minified production code described here in #2002 by removing a faulty validator.

@markbrouch markbrouch changed the title fix singer validate bug fix(middleware-sdk-transcribe-streaming) remove validateSigner Aug 14, 2021
@markbrouch markbrouch force-pushed the fix-signer-validate-bug branch 2 times, most recently from 1e88a72 to b88ba25 Compare August 14, 2021 02:19
@markbrouch markbrouch changed the title fix(middleware-sdk-transcribe-streaming) remove validateSigner fix(middleware-sdk-transcribe-streaming): remove validateSigner Aug 14, 2021
@markbrouch markbrouch changed the title fix(middleware-sdk-transcribe-streaming): remove validateSigner fix(middleware-sdk-transcribe-streaming): validate signer Aug 14, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@cbdcd9c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2676   +/-   ##
=======================================
  Coverage        ?   58.87%           
=======================================
  Files           ?      521           
  Lines           ?    28946           
  Branches        ?     7172           
=======================================
  Hits            ?    17041           
  Misses          ?    11905           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdcd9c...52b9cea. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 52b9cea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants