Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-signing): update systemClockOffset on error #2686

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 18, 2021

Issue

Fixes: #2208

Description

Updates systemClockOffset on error in middleware-signing

Testing

  • CI
  • Updated system time offset to more than 15 minutes and verified that request is successful in the second retry
Code
import { S3 } from "../aws-sdk-js-v3/clients/client-s3/dist/cjs/index.js";

const region = "us-east-1";
const client = new S3({ region, logger: console });
await client.listBuckets({});
Output
{
  clientName: 'S3Client',
  commandName: 'ListBucketsCommand',
  input: {},
  output: {
    Buckets: [ [Object], [Object], [Object], [Object], [Object], [Object] ],
    Owner: {
      DisplayName: 'trivikr',
      ID: 'f36465be55e5435ccc8357d4857b23522cbf71100368115f086c017f5092617a'
    }
  },
  metadata: {
    httpStatusCode: 200,
    requestId: undefined,
    extendedRequestId: '/C9sJk2+qWrvZmgSC9L2VacyLS/QuTgZ0ICvtru4Kh0uc4ZUJBxfrVg+oDQj5r3Cnt+URA9fJJE=',
    cfId: undefined,
    attempts: 2,
    totalRetryDelay: 190
  }
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@6c0f44f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2686   +/-   ##
=======================================
  Coverage        ?   58.94%           
=======================================
  Files           ?      531           
  Lines           ?    29002           
  Branches        ?     7191           
=======================================
  Hits            ?    17096           
  Misses          ?    11906           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0f44f...51d26d4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
@trivikr trivikr deleted the update-systemClockOffset-on-error branch October 7, 2021 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestTimeTooSkewed even though on version 3 and correctClockSkew is true by default
3 participants