fix(middleware-sdk-rds): double encoding the presigned url #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Aug 26, 2021
|
I need more test as this plugin is also used in DocDB and Neptune clients |
…cation api According to codegen, StartDBInstanceAutomatedBackupsReplication API should be supported with cross-region copy.
AllanZhengYP
force-pushed
the
fix-escape-presign-url
branch
from
c5ef549
to
538e002
Compare
Codecov Report
@@ Coverage Diff @@
## main #2711 +/- ##
=======================================
Coverage ? 61.32%
=======================================
Files ? 537
Lines ? 27462
Branches ? 6708
=======================================
Hits ? 16842
Misses ? 10620
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
approved these changes
Aug 30, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ref JS-2709
Description
Previously users will see
PreSignedurl could not be authenticatederror for cross regional copy of snapshots. This is because the presigned url populated automatically be SDK was URIEncoded twice in the body. This change remove the extra uri encoding.This change basically is revert of #773
Testing
[UPDATE] Unit test, Manual test API:
RDS: :CopyDBClusterSnapshotRDS::CreateDBClusterRDS::CopyDBSnapshotRDS::CreateDBInstanceReadReplicaRDS::StartDBInstanceAutomatedBackupsReplicationDocDB::CopyDBClusterSnapshotNeptune::CopyDBClusterSnapshotNeptune::CreateDBCluster.I remove the support of presigned URL on
DocDB::CreateDBCluster, because the source identifier parameter does not exist, so a URL cannot be generated.Neptune::CopyDBClusterSnapshot,Neptune::CreateDBClusterpresigned URL is not supported currently, but I find it's ok to still populate the value, the server side doesn't complain.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.