feat(codegen): reject null in non-sparse collections #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2771 +/- ##
=======================================
Coverage 60.15% 60.15%
=======================================
Files 548 548
Lines 28586 28586
Branches 6997 6997
=======================================
Hits 17196 17196
Misses 11390 11390 Continue to review full report at Codecov.
|
AllanZhengYP
approved these changes
Sep 9, 2021
JordonPhillips
force-pushed
the
non-sparse-ssdk
branch
from
11e8f2e
to
45712cb
Compare
This updates list parsing for SSDKs to throw an error whenever a null value shows up in a list or set that isn't meant to be sparse. Clients remain tolerant of these nulls to preserve compatibility with services that are not so strict.
JordonPhillips
force-pushed
the
non-sparse-ssdk
branch
from
45712cb
to
ae09d4b
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
This updates list parsing for SSDKs to throw an error whenever a
null value shows up in a list or set that isn't meant to be sparse.
Clients remain tolerant of these nulls to preserve compatibility with
services that are not so strict.
Testing
Tests from
mainon smithy were run.Additional context
n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.