feat(s3): support generating endpoints from multi-region access point #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cfb3fff.
AllanZhengYP
force-pushed
the
reintro-mrap
branch
from
d23451a
to
59ee218
Compare
Codecov Report
@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
+ Coverage 60.17% 60.41% +0.24%
==========================================
Files 548 554 +6
Lines 28592 28883 +291
Branches 7000 7076 +76
==========================================
+ Hits 17204 17450 +246
- Misses 11388 11433 +45
Continue to review full report at Codecov.
|
AllanZhengYP
force-pushed
the
reintro-mrap
branch
from
59ee218
to
ed7cc09
Compare
… usage This makes sure the type of CRT package is available and the Lerna builds packages in right order--build crt signer package before buiding s3 middleware package.
AllanZhengYP
force-pushed
the
reintro-mrap
branch
from
ed7cc09
to
2c6efa8
Compare
AllanZhengYP
commented
Sep 20, 2021
AllanZhengYP
commented
Sep 20, 2021
AllanZhengYP
force-pushed
the
reintro-mrap
branch
from
f2874d5
to
d42f69e
Compare
trivikr
approved these changes
Sep 20, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Reverts: cfb3fff.
This change marks
@aws-sdk/signature-v4-crtpackage is peer dependency. It makes sure the SDK won't install the package out-of-box. Because the@aws-sdk/signature-v4-crtpackage contains native code, it takes up 10MB on disk, and it is only required for signing MRAP request. So for users requiring this feature, they need to install the package explicitly.TODO: Create
Known Issuesto the README.md too document users to install@aws-sdk/signature-v4-crtpackage explicitlyTesting
Manual test(Lambda, Lambda with bundler, Browser with Webpack), Unit test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.