fix(middleware-sdk-s3): missing dependency with esbuild #2814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2806
Description
esbuild will try to bundle the optional dependency
@aws-sdk/signature-v4-crt
and will throw if the dependency is not installed. Unlike Webpack, there's no good way to suppress it with magical comments.One way to solve this is to wrap the
await import()
withtry...catch
, because esBuild supresses this error explicitly. However, in generated code the import is wrapped by tslib import helper. I didn't remove the import helper because it may break the ES6 class polyfill provided by import helper. Instead, we use the Node.jsrequire()
here because:require()
won't be analyzed by bundler, so@aws-sdk/signature-v4-crt
is not requiredBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.