Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-cognito-identity): import client from new location in src #2858

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 1, 2021

Issue

Internal JS-2860

Description

imports client from src location for client-cognito-identity tests.

Commit which fixed e2e tests in PR: 928ce1c (#2845)
Updating import for test/e2e/CognitoIdentity.ispec.ts was missed.

Testing

The e2e tests for client-cognito-identity were successful!

$ pwd
/home/trivikr/workspace/aws-sdk-js-v3/clients/client-cognito-identity

$ AWS_SMOKE_TEST_REGION=[Region] AWS_SMOKE_TEST_IDENTITY_POOL_ID=[IdentityPoolId] yarn test:e2e
...
Chrome Headless 94.0.4606.61 (Linux x86_64): Executed 1 of 1 SUCCESS (0.216 secs / 0.214 secs)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review October 1, 2021 20:17
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add the same in the code gen?

@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2021

Should we also add the same in the code gen?

The e2e tests for clients are not codegen. What are your referring to?

@trivikr trivikr merged commit c8cb449 into aws:main Oct 1, 2021
@trivikr trivikr deleted the fix-cognito-test-e2e branch October 1, 2021 20:31
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants