feat(codegen): test non-AWS client builds #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
force-pushed
the
generic-client-tests
branch
3 times, most recently
from
cc4b82b
to
e23bb54
Compare
adamthom-amzn
force-pushed
the
generic-client-tests
branch
from
e23bb54
to
54b9e72
Compare
Codecov Report
@@ Coverage Diff @@
## main #2876 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 554 554
Lines 28886 28886
Branches 7072 7072
=======================================
Hits 17453 17453
Misses 11433 11433
Continue to review full report at Codecov.
|
Generate a non-AWS client and add a GitHub action that verifies that it will compile.
adamthom-amzn
force-pushed
the
generic-client-tests
branch
from
54b9e72
to
e6ff1c6
Compare
trivikr
approved these changes
Oct 6, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate a non-AWS client and add a GitHub action that verifies that it will compile.
Testing
Ran the tests manually locally, and in this PR.
Test failing due to a non-@ts-ignored import: https://github.com/aws/aws-sdk-js-v3/pull/2876/checks?check_run_id=3820762025They should pass once rebased upon a merged #2875By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.