feat(codegen): enable SSDK validation protocol tests #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a separate set of models from malformed request tests, Smithy publishes malformed request tests for built-in validation, which exercises how the SSDK rejects requests that do not obey the modeled constraints (such as length, pattern, etc).
Codecov Report
@@ Coverage Diff @@
## main #2884 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 558 558
Lines 30249 30249
Branches 7443 7443
=======================================
Hits 17719 17719
Misses 12530 12530 Continue to review full report at Codecov.
|
JordonPhillips
approved these changes
Oct 11, 2021
trivikr
approved these changes
Oct 13, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a separate set of models from malformed request tests, Smithy publishes
malformed request tests for built-in validation, which exercises how the SSDK
rejects requests that do not obey the modeled constraints (such as length,
pattern, etc).
Testing
Ran
yarn generate-clients -s && yarn test:server-protocolslocally with smithy-lang/smithy-typescript#450 and smithy-lang/smithy-typescript#449 checked out and linked locally.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.