feat(karma-credential-loader): mark package as private #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Oct 29, 2021
AllanZhengYP
force-pushed
the
fix-creds-loader
branch
from
fefa735
to
e43ebc7
Compare
Codecov Report
@@ Coverage Diff @@
## main #2959 +/- ##
=======================================
Coverage 58.60% 58.60%
=======================================
Files 561 561
Lines 30272 30272
Branches 7452 7452
=======================================
Hits 17742 17742
Misses 12530 12530 Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No other package is using it externally except for @aws-crypto/integration-browser, which is also only used for testing the crypto helpers. So we no longer publish new versions.
This change also supports for assume role credentials. Our automated end-to-end test needs temporary credentials to run.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.